fix(cubesql): Disable filter pushdown over Filter(CrossJoin) #9474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9474 +/- ##
==========================================
- Coverage 80.31% 80.27% -0.04%
==========================================
Files 395 395
Lines 97349 97355 +6
Branches 2278 2278
==========================================
- Hits 78181 78150 -31
- Misses 18860 18897 +37
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
approved these changes
Apr 23, 2025
MazterQyou
approved these changes
Apr 24, 2025
This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins
mcheshkov
force-pushed
the
filter-pushdown-vs-join
branch
from
8826ccc to
4d9020c
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…#9474) This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins